GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6311

    [FLINK-9811][rest] Add test for jar handler interactions 

    Based on #6310.
    
    ## What is the purpose of the change
    
    This PR adds an ITCase for the interactions between jar handlers.
    
    The test goes through the following life-cycle:
    * upload jar
    * list jars, expect uploaded jar
    * show plan for uploaded jar
    * run uploaded jar, expect failure during upload to blobserver (no cluster 
is started)
    * delete uploaded jar
    * list jars, expect empty list
    
    ## Brief change log
    
    * sync dispatcher hostname retrieval in `JarRunHandler` with 
`JobSubmitHandler`
    
    *  add `TestProgram` class and `maven-jar-plugin` execution to create a 
test jar for the test
    * modify visibility of various `*MessageParameter` classes to make them 
usable for java code
    * add `JarSubmissionITCase`
    
    ## Verifying this change
    
    Manually verified. The assertions made are fairly straight-forward.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9811

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6311.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6311
    
----
commit 4d305f1d33668664edba5e6af198e4735a76dad4
Author: zentol <chesnay@...>
Date:   2018-07-11T16:19:53Z

    [FLINK-9810][rest] Close jar file in JarListHandler

commit b7ff80f59f7df1999f3fe0e72945b45efeec1607
Author: zentol <chesnay@...>
Date:   2018-07-11T16:37:15Z

    [hotfix][rest] Simplify dispatcher host retrieval
    
    Adjusted to work like the JobSubmitHandler.

commit b04fa0834269086cab8d87df021e9037b7353be8
Author: zentol <chesnay@...>
Date:   2018-07-11T16:41:06Z

    [FLINK-9811][rest] Add test for jar handler interactions

----


---

Reply via email to