[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541231#comment-16541231 ]
ASF GitHub Bot commented on FLINK-9829: --------------------------------------- GitHub user lamber-ken opened a pull request: https://github.com/apache/flink/pull/6321 [FLINK-9829] fix the wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java ## What is the purpose of the change - fix the wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java ## Brief change log - The wrapper classes should be compared by equals method rather than by symbol of '==' directly - should use BigDecimal's equal method ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (JavaDocs) You can merge this pull request into a Git repository by running: $ git pull https://github.com/lamber-ken/flink FLINK-9829 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6321.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6321 ---- commit cebe6b9d6f4c812c336581545623f430d5cb0b58 Author: lamber-ken <!@...> Date: 2018-07-12T06:53:53Z [FLINK-9829] fix the wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java ---- > The wrapper classes be compared by symbol of '==' directly in > BigDecSerializer.java > ----------------------------------------------------------------------------------- > > Key: FLINK-9829 > URL: https://issues.apache.org/jira/browse/FLINK-9829 > Project: Flink > Issue Type: Improvement > Components: Core > Affects Versions: 1.5.0 > Reporter: lamber-ken > Assignee: lamber-ken > Priority: Major > Labels: pull-request-available > Fix For: 1.5.2 > > > The wrapper classes should be compared by equals method rather than by symbol > of '==' directly in BigDecSerializer.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)