[
https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542991#comment-16542991
]
ASF GitHub Bot commented on FLINK-9829:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6321#discussion_r202335561
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigDecSerializer.java
---
@@ -69,17 +69,17 @@ public void serialize(BigDecimal record, DataOutputView
target) throws IOExcepti
}
// fast paths for 0, 1, 10
// only reference equality is checked because equals would be
too expensive
--- End diff --
The code adheres to the API provided by `BigInteger`, so this is fine as
far as I'm concerned.
It would be a different story if, say, we would use reference equality for
`2`, since that relies an implementation detail that isn't exposed anywhere.
> The wrapper classes be compared by symbol of '==' directly in
> BigDecSerializer.java
> -----------------------------------------------------------------------------------
>
> Key: FLINK-9829
> URL: https://issues.apache.org/jira/browse/FLINK-9829
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.5.0
> Reporter: lamber-ken
> Assignee: lamber-ken
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.2
>
>
> The wrapper classes should be compared by equals method rather than by symbol
> of '==' directly in BigDecSerializer.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
