Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6321#discussion_r202075894
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigDecSerializer.java
 ---
    @@ -69,17 +69,17 @@ public void serialize(BigDecimal record, DataOutputView 
target) throws IOExcepti
                }
                // fast paths for 0, 1, 10
                // only reference equality is checked because equals would be 
too expensive
    --- End diff --
    
    No.
    In terms of performance, this is OK, but from the point of view of language 
specification, may be it's better to use `equals` method.


---

Reply via email to