Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6321#discussion_r202335561
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigDecSerializer.java
---
@@ -69,17 +69,17 @@ public void serialize(BigDecimal record, DataOutputView
target) throws IOExcepti
}
// fast paths for 0, 1, 10
// only reference equality is checked because equals would be
too expensive
--- End diff --
The code adheres to the API provided by `BigInteger`, so this is fine as
far as I'm concerned.
It would be a different story if, say, we would use reference equality for
`2`, since that relies an implementation detail that isn't exposed anywhere.
---
