[
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543259#comment-16543259
]
ASF GitHub Bot commented on FLINK-8558:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202356170
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/CsvTableSinkFactory.scala
---
@@ -104,17 +100,12 @@ class CsvTableSinkFactory
"Encodings that differ from the schema are not supported yet for
CsvTableSink.")
}
- toScala(params.getOptionalString(CONNECTOR_PATH))
- .foreach(csvTableSinkBuilder.path)
- toScala(params.getOptionalInt(NUM_FILES))
- .foreach(n => csvTableSinkBuilder.numFiles(n))
- toScala(params.getOptionalString(WRITE_MODE))
- .foreach(csvTableSinkBuilder.writeMode)
- toScala(params.getOptionalString(FORMAT_FIELD_DELIMITER))
- .foreach(csvTableSinkBuilder.fieldDelimiter)
-
- csvTableSinkBuilder
- .build()
+ val path = params.getString(CONNECTOR_PATH)
--- End diff --
ditto fixup
> Add unified format interfaces and format discovery
> --------------------------------------------------
>
> Key: FLINK-8558
> URL: https://issues.apache.org/jira/browse/FLINK-8558
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> In the last release, we introduced a new module {{flink-formats}}. Currently
> only {{flink-avro}} is located there but we will add more formats such as
> {{flink-json}}, {{flink-protobuf}}, and so on. For better separation of
> concerns we want decouple connectors from formats: e.g., remove
> {{KafkaAvroTableSource}} and {{KafkaJsonTableSource}}.
> A newly introduced {{FormatFactory}} will use Java service loaders to
> discovery available formats in the classpath (similar to how file systems are
> discovered now). A {{Format}} will provide a method for converting {{byte[]}}
> to target record type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
