[
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543244#comment-16543244
]
ASF GitHub Bot commented on FLINK-8558:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202333467
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -143,118 +143,82 @@ case class CatalogAlreadyExistException(
}
/**
- * Exception for not finding a [[TableFormatFactory]] for the
- * given properties.
+ * Exception for not finding a [[TableFactory]] for the given properties.
*
* @param message message that indicates the current matching step
* @param factoryClass required factory class
- * @param formatFactories all found factories
- * @param properties properties that describe the table format
+ * @param factories all found factories
+ * @param properties properties that describe the configuration
* @param cause the cause
*/
-case class NoMatchingTableFormatException(
+case class NoMatchingTableFactoryException(
message: String,
factoryClass: Class[_],
- formatFactories: Seq[TableFormatFactory[_]],
+ factories: Seq[TableFactory],
properties: Map[String, String],
cause: Throwable)
extends RuntimeException(
--- End diff --
side note: shouldn't our exception inherit from `FlinkTableException` or
sth like that?
> Add unified format interfaces and format discovery
> --------------------------------------------------
>
> Key: FLINK-8558
> URL: https://issues.apache.org/jira/browse/FLINK-8558
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> In the last release, we introduced a new module {{flink-formats}}. Currently
> only {{flink-avro}} is located there but we will add more formats such as
> {{flink-json}}, {{flink-protobuf}}, and so on. For better separation of
> concerns we want decouple connectors from formats: e.g., remove
> {{KafkaAvroTableSource}} and {{KafkaJsonTableSource}}.
> A newly introduced {{FormatFactory}} will use Java service loaders to
> discovery available formats in the classpath (similar to how file systems are
> discovered now). A {{Format}} will provide a method for converting {{byte[]}}
> to target record type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
