Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/952#issuecomment-127139227
> ...have it actually wrap the configuration, and have all the "getX()"
methods delegate to the config,
> while all the "setX()" methods fail with an exception.
That was my earlier solution [which is gone now because I rebased and force
pushed :( ]. You're right though. It'd certainly make the initialization
easier, but adds an additional calling overhead for every getter method [which
are the most frequent. Initialization will be done exactly once]. IMO that's
not a good idea.
>I think that silently failing is not a good idea in this case. Silent
failures always keep people >wondering why things don't behave like they
expect. It needs to fail with an exception here.
That's easy enough! :') I just wasn't sure.
>For the test it is important that it catches the case where someone adds a
method (for example >"setStringArray()") to the base class and does not
override it in the superclass.
The assumption being that any modifiers will be named `set*`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
