Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/952#issuecomment-127184585
Looks good, modulo some styles...
- No need to override all "set*" methods, when the internal set method is
overridden.
- Final modifiers should be used for new members where possible,
consistent with the remaining code
- Let's not add new Scala classes. We decided that in the long run, it
would be good to have the runtime pure Java again.
I need this quite soon, so let me take this over...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
