[
https://issues.apache.org/jira/browse/FLINK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545034#comment-16545034
]
ASF GitHub Bot commented on FLINK-9380:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6289#discussion_r202631900
--- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh ---
@@ -58,20 +63,32 @@ function run_test {
fi
fi
- if [[ ${exit_code} != 0 ]]; then
+ if [[ ${exit_code} == 0 ]]; then
+ cleanup
+ else
exit "${exit_code}"
fi
}
-# Shuts down the cluster and cleans up all temporary folders and files.
Make sure to clean up even in case of failures.
+# Shuts down cluster and reverts changes to cluster configs
+function cleanup_proc {
+ shutdown_all
+ revert_default_config
+}
+
+# Cleans up all temporary folders and files
+function cleanup_files {
--- End diff --
function name is too generic, rename to `cleanup_temp_files`
> Failing end-to-end tests should not clean up logs
> -------------------------------------------------
>
> Key: FLINK-9380
> URL: https://issues.apache.org/jira/browse/FLINK-9380
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Till Rohrmann
> Assignee: Deepak Sharma
> Priority: Critical
> Labels: pull-request-available, test-stability
> Fix For: 1.5.2, 1.6.0
>
>
> Some of the end-to-end tests clean up their logs also in the failure case.
> This makes debugging and understanding the problem extremely difficult.
> Ideally, the scripts says where it stored the respective logs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
