[
https://issues.apache.org/jira/browse/FLINK-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545488#comment-16545488
]
ASF GitHub Bot commented on FLINK-9762:
---------------------------------------
Github user JTaky commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202756536
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -250,6 +250,10 @@ public static Configuration
generateTaskManagerConfiguration(
cfg.setInteger(TaskManagerOptions.NUM_TASK_SLOTS,
numSlots);
}
+ if (!baseConfig.containsKey(CoreOptions.TMP_DIRS_OVERRIDDEN)){
+ cfg.setString(CoreOptions.TMP_DIRS, ""); //
HACK: emulate removal for the given key
+ }
--- End diff --
Agree, magic values are the dirtiest way.
Will go with a 'clear' (probably remove, in order to mimic java collection
API) method.
Didn't get the point with clone method. Is it in order to factorize this 4
lines or do you want to make it generic and use for all custom settings? In
such case we should extract list of predicates per each configuration which
looks quite complex as an API
> CoreOptions.TMP_DIRS wrongly managed on Yarn
> --------------------------------------------
>
> Key: FLINK-9762
> URL: https://issues.apache.org/jira/browse/FLINK-9762
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Affects Versions: 1.5.0
> Reporter: Oleksandr Nitavskyi
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.2, 1.6.0
>
>
> The issue on Yarn is that it is impossible to have different LOCAL_DIRS on
> JobManager and TaskManager, despite LOCAL_DIRS value depends on the container.
> The issue is that CoreOptions.TMP_DIRS is configured to the default value
> during JobManager initialization and added to the configuration object. When
> TaskManager is launched the appropriate configuration object is cloned with
> LOCAL_DIRS which makes sense only for Job Manager container. When YARN
> container with TaskManager from his point of view CoreOptions.TMP_DIRS is
> always equal either to path in flink.yml or to the or to the LOCAL_DIRS of
> Job Manager (default behaviour). Is TaskManager’s container do not have an
> access to another folders, that folders allocated by YARN TaskManager cannot
> be started.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
