[ 
https://issues.apache.org/jira/browse/FLINK-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541870#comment-16541870
 ] 

ASF GitHub Bot commented on FLINK-9762:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6284#discussion_r202082557
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
 ---
    @@ -467,4 +471,22 @@ public static String getStartCommand(String template,
                }
                return template;
        }
    +
    +   /**
    +    * Set temporary configuration directories if necesary
    +    *
    +    * @param configuration flink config to patch
    +    * @param defaultDirs in case no tmp directories is set, next 
directories will be applied
    +    */
    +   public static void setTmpDirectoriesConfig(Configuration configuration, 
String defaultDirs){
    +           if (configuration.contains(CoreOptions.TMP_DIRS) && 
!configuration.getString(CoreOptions.TMP_DIRS).isEmpty()) {
    +                   LOG.info("Overriding Fink's temporary file directories 
with those " +
    +                           "specified in the Flink config: " + 
configuration.getValue(CoreOptions.TMP_DIRS));
    --- End diff --
    
    Should use logging placeholder `{}`


> CoreOptions.TMP_DIRS wrongly managed on Yarn
> --------------------------------------------
>
>                 Key: FLINK-9762
>                 URL: https://issues.apache.org/jira/browse/FLINK-9762
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>    Affects Versions: 1.5.0
>            Reporter: Oleksandr Nitavskyi
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.2, 1.6.0
>
>
> The issue on Yarn is that it is impossible to have different LOCAL_DIRS on 
> JobManager and TaskManager, despite LOCAL_DIRS value depends on the container.
> The issue is that CoreOptions.TMP_DIRS is configured to the default value 
> during JobManager initialization and added to the configuration object. When 
> TaskManager is launched the appropriate configuration object is cloned with 
> LOCAL_DIRS which makes sense only for Job Manager container. When YARN 
> container with TaskManager from his point of view CoreOptions.TMP_DIRS is 
> always equal either to path in flink.yml or to the or to the LOCAL_DIRS of 
> Job Manager (default behaviour). Is TaskManager’s container do not have an 
> access to another folders, that folders allocated by YARN TaskManager cannot 
> be started.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to