[
https://issues.apache.org/jira/browse/FLINK-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550521#comment-16550521
]
ASF GitHub Bot commented on FLINK-9902:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203976558
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java
---
@@ -88,20 +80,17 @@ public void testTumblingTimeWindow() {
final int numElementsPerKey = 3000;
final int windowSize = 100;
final int numKeys = 1;
- FailingSource.reset();
try {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.setParallelism(PARALLELISM);
env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime);
env.enableCheckpointing(100);
-
env.setRestartStrategy(RestartStrategies.fixedDelayRestart(3, 0));
+
env.setRestartStrategy(RestartStrategies.fixedDelayRestart(1, 0));
env.getConfig().disableSysoutLogging();
env
- .addSource(new FailingSource(numKeys,
- numElementsPerKey,
- numElementsPerKey / 3))
+ .addSource(new FailingSource(new
EventTimeWindowCheckpointingITCase.KeyedEventTimeGenerator(numKeys,
windowSize), numElementsPerKey))
--- End diff --
Reusing the small helper funs from other tests to me always seems
problematic when the names of that test changes or when the functions change.
Duplicating them here will duplicate code but in the long run is probably
better. WDYT?
> Improve and refactor window checkpointing IT cases
> --------------------------------------------------
>
> Key: FLINK-9902
> URL: https://issues.apache.org/jira/browse/FLINK-9902
> Project: Flink
> Issue Type: Test
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0, 1.7.0
>
>
> Windowing IT cases currently have a lot of duplicated code that could be
> unified and deduplicated. Furthermore, the test will also not fail on
> problems with timer snapshots because either there are no timers in the
> snapshot or all timers will still be re-inserted before they trigger. We can
> cover timers as well if we change this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
