[
https://issues.apache.org/jira/browse/FLINK-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550519#comment-16550519
]
ASF GitHub Bot commented on FLINK-9902:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203976258
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java
---
@@ -133,9 +122,12 @@ public void apply(
out.collect(new
Tuple4<>(key, window.getStart(), window.getEnd(), new IntType(sum)));
}
})
- .addSink(new ValidatingSink(numKeys,
numElementsPerKey / windowSize)).setParallelism(1);
+ .addSink(new ValidatingSink<>(
+ new
EventTimeWindowCheckpointingITCase.SinkValidatorUpdateFun(numElementsPerKey),
+ new
EventTimeWindowCheckpointingITCase.SinkValidatorCheckFun(numKeys,
numElementsPerKey, windowSize)))
+ .setParallelism(1);
- tryExecute(env, "Tumbling Window Test");
+ env.execute("Tumbling Window Test");
--- End diff --
Why is this not using `tryExecute()` anymore?
> Improve and refactor window checkpointing IT cases
> --------------------------------------------------
>
> Key: FLINK-9902
> URL: https://issues.apache.org/jira/browse/FLINK-9902
> Project: Flink
> Issue Type: Test
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0, 1.7.0
>
>
> Windowing IT cases currently have a lot of duplicated code that could be
> unified and deduplicated. Furthermore, the test will also not fail on
> problems with timer snapshots because either there are no timers in the
> snapshot or all timers will still be re-inserted before they trigger. We can
> cover timers as well if we change this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
