[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

[pnowojski]

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6355#discussion_r204324645
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java
 ---
    @@ -175,7 +183,6 @@ ChannelFuture connect(final InetSocketAddress 
serverSocketAddress) {
                bootstrap.handler(new ChannelInitializer<SocketChannel>() {
                        @Override
                        public void initChannel(SocketChannel channel) throws 
Exception {
    -
                                // SSL handler should be added first in the 
pipeline
                                if (clientSSLContext != null) {
    --- End diff --
    
    `checkState(!clientSSLContext.isEmpty())`? How can it ever be null?


---