[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

[pnowojski]

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6355#discussion_r204298813
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConfig.java
 ---
    @@ -189,23 +192,34 @@ public TransportType getTransportType() {
                }
        }
     
    -   public SSLContext createClientSSLContext() throws Exception {
    +   @Nullable
    --- End diff --
    
    `Optional` and ditto in other places. `@Nullable` is almost worthless 
without enforcing compile errors.


---