[
https://issues.apache.org/jira/browse/FLINK-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653276#comment-14653276
]
ASF GitHub Bot commented on FLINK-2472:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/979#discussion_r36167357
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java
---
@@ -49,6 +55,28 @@
// Actor which submits a job to the JobManager via this actor
private ActorRef submitter;
+ // timeout for a message from the job manager
+ private static FiniteDuration JOB_CLIENT_JOB_MANAGER_TIMEOUT = new
FiniteDuration(10000, TimeUnit.MILLISECONDS);
+
+ // heartbeat interval for pinging the job manager for job status
+ private static FiniteDuration JOB_CLIENT_HEARTBEAT_INTERVAL = new
FiniteDuration(5000, TimeUnit.MILLISECONDS);
+
+ // initial time delay before starting pinging job manager over regular
intervals
+ private static FiniteDuration JOB_CLIENT_INITIAL_PING_DELAY = new
FiniteDuration(500, TimeUnit.MILLISECONDS);
+
+ // maximum waiting time for a job to go to running status (milliseconds)
+ // setting highly conservative limit for now. This should ideally be in
Configuration.
+ private static long JOB_CLIENT_JOB_STATUS_TIMEOUT = 30000;
--- End diff --
These values should be configurable. Thus they should be definable in the
`flink-conf.yaml` file.
> Make the JobClientActor check periodically if the submitted Job is still
> running and if the JobManager is still alive
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-2472
> URL: https://issues.apache.org/jira/browse/FLINK-2472
> Project: Flink
> Issue Type: Improvement
> Reporter: Till Rohrmann
> Assignee: Sachin Goel
>
> In case that the {{JobManager}} dies without notifying possibly connected
> {{JobClientActors}} or if the job execution finishes without sending the
> {{SerializedJobExecutionResult}} back to the {{JobClientActor}}, it might
> happen that a {{JobClient.submitJobAndWait}} never returns.
> I propose to let the {{JobClientActor}} periodically check whether the
> {{JobManager}} is still alive and whether the submitted job is still running.
> If not, then the {{JobClientActor}} should return an exception to complete
> the waiting future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
