zentol commented on a change in pull request #6421: [FLINK-9944][tests] Cleanup
end-to-end test poms
URL: https://github.com/apache/flink/pull/6421#discussion_r205158644
##########
File path: flink-end-to-end-tests/flink-bucketing-sink-test/pom.xml
##########
@@ -72,30 +66,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.0.0</version>
<executions>
<execution>
+
<id>BucketingSinkTestProgram</id>
Review comment:
There are multiple benefits to introducing an explicit id.
They reduce the chance for clashes between executions, as executions without
IDs are treated as a single execution.
The ID is printed when the shade-plugin is executed, which makes it easier
to associate the output to a specific shade-plugin execution.
Finally, with newer maven versions you can invoke specific executions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
