zentol commented on a change in pull request #6421: [FLINK-9944][tests] Cleanup
end-to-end test poms
URL: https://github.com/apache/flink/pull/6421#discussion_r205185733
##########
File path: flink-end-to-end-tests/flink-bucketing-sink-test/pom.xml
##########
@@ -72,30 +66,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.0.0</version>
<executions>
<execution>
+
<id>BucketingSinkTestProgram</id>
Review comment:
point 1 isn't irrelevant in terms of maintainability; without an execution
ID it could happen fairly easily that a shade-plugin configuration in any of
the parent modules could modify the behavior accidentally.
The last point is also still relevant as there are in fact 2 `shade-plugin`
executions defined here, `shade-flink` inherited from the root pom and the one
(or two) in the actual module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
