[
https://issues.apache.org/jira/browse/FLINK-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555786#comment-16555786
]
ASF GitHub Bot commented on FLINK-9942:
---------------------------------------
dawidwys commented on a change in pull request #6416: [FLINK-9942][rest] Guard
handlers against null fields
URL: https://github.com/apache/flink/pull/6416#discussion_r205139837
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitRequestBody.java
##########
@@ -34,7 +35,7 @@
*/
public final class JobSubmitRequestBody implements RequestBody {
- private static final String FIELD_NAME_JOB_GRAPH = "jobGraphFileName";
+ public static final String FIELD_NAME_JOB_GRAPH = "jobGraphFileName";
Review comment:
Ignore my comments. I've checked it and the `required` property is ignored
by the `ObjectMapper`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Guard handlers against null fields in requests
> ----------------------------------------------
>
> Key: FLINK-9942
> URL: https://issues.apache.org/jira/browse/FLINK-9942
> Project: Flink
> Issue Type: Improvement
> Components: REST
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
>
> In FLINK-8233 the {{ObjectMapper}} used for the REST API was modified to not
> fail on missing creator properties. This means that any field for any request
> may be null.
> Since fields not being null was an assumption that handlers were previously
> built on, we now have to scan every implementation to ensure they can't fail
> with an NPE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
