[
https://issues.apache.org/jira/browse/FLINK-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559981#comment-16559981
]
ASF GitHub Bot commented on FLINK-9986:
---------------------------------------
zentol opened a new pull request #6443: [FLINK-9986][build] Only include
commit info in .version.properties file
URL: https://github.com/apache/flink/pull/6443
## What is the purpose of the change
This PR modifies the `git-commit-id-plugin` configuration to only contain
information about the actual commit, excluding information about the build,
remote and branch.
This PR is based on #6442 since one of the now removed properties is still
used.
## Brief change log
* bump plugin version to earliest version supporting inclusions
* modify configuration
## Verifying this change
* run `mvn package` in flink-runtime and check
`src/main/resources/.version.properties`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove unnecessary information from .version.properties file
> ------------------------------------------------------------
>
> Key: FLINK-9986
> URL: https://issues.apache.org/jira/browse/FLINK-9986
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.4.2, 1.5.1, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> To log the revision {{flink-runtime}} creates a {{.version.properties}} file
> using the {{git-commit-id-plugin}} that is stored within the jar.
> Here's an example:
> {code}
> git.commit.id.abbrev=1a9b648
> [email protected]
> git.commit.message.full=Commit for release 1.5.2\n
> git.commit.id=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
> git.commit.message.short=Commit for release 1.5.2
> git.commit.user.name=zentol
> git.build.user.name=zentol
> [email protected]
> git.branch=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
> git.commit.time=25.07.2018 @ 17\:10\:13 GMT
> git.build.time=25.07.2018 @ 20\:47\:15 GMT
> git.remote.origin.url=https\://github.com/zentol/flink.git
> {code}
> most of this information isn't used, as flink-runtime only access
> {{git.commit.id.abbrev}} and {{git.commit.time}}.
> The build, remote and branch information should be removed as they are
> neither relevant, nor consistent, as releases can be created on any branch,
> under any git alias, against any remote.
> To exclude properties we have to bump the plugin version to 2.1.9.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
