TisonKun commented on a change in pull request #6446: [FLINK-9240] Avoid
deprecated Akka methods
URL: https://github.com/apache/flink/pull/6446#discussion_r205956009
##########
File path:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
##########
@@ -2288,11 +2291,10 @@ object JobManager {
catch {
case t: Throwable =>
LOG.error("Error while starting up JobManager", t)
- try {
- jobManagerSystem.shutdown()
- } catch {
- case tt: Throwable => LOG.warn("Could not cleanly shut down actor
system", tt)
- }
+ jobManagerSystem.terminate().onComplete {
+ case scala.util.Success(_) =>
+ case scala.util.Failure(tt) => LOG.warn("Could not cleanly shut down
actor system", tt)
+
}(org.apache.flink.runtime.concurrent.Executors.directExecutionContext())
Review comment:
also here could we `import static`, in scala I think it might be `import`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
