TisonKun commented on a change in pull request #6446: [FLINK-9240] Avoid
deprecated Akka methods
URL: https://github.com/apache/flink/pull/6446#discussion_r205956045
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/akka/DefaultQuarantineHandler.java
##########
@@ -65,11 +66,13 @@ public void hasQuarantined(String remoteSystem,
ActorSystem actorSystem) {
private void shutdownActorSystem(ActorSystem actorSystem) {
// shut the actor system down
- actorSystem.shutdown();
+ actorSystem.terminate();
try {
// give it some time to complete the shutdown
- actorSystem.awaitTermination(timeout);
+ Await.ready(actorSystem.whenTerminated(), timeout);
+ } catch (InterruptedException |
java.util.concurrent.TimeoutException e) {
Review comment:
`java.util.concurrent.TimeoutException` could be simplified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
