[ 
https://issues.apache.org/jira/browse/FLINK-10006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565516#comment-16565516
 ] 

ASF GitHub Bot commented on FLINK-10006:
----------------------------------------

yanghua commented on a change in pull request #6470: [FLINK-10006][network] 
improve logging in BarrierBuffer: prepend owning task name
URL: https://github.com/apache/flink/pull/6470#discussion_r206931865
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
 ##########
 @@ -129,6 +129,12 @@ public int getNumberOfInputChannels() {
                return totalNumberOfInputChannels;
        }
 
+       @Override
+       public String getOwningTaskName() {
+               // all input dates have the same owning task
 
 Review comment:
   "dates" ? or "gates"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve logging in BarrierBuffer
> --------------------------------
>
>                 Key: FLINK-10006
>                 URL: https://issues.apache.org/jira/browse/FLINK-10006
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.5.2, 1.6.0, 1.7.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>
> Almost all log messages of {{BarrierBuffer}} do not contain the task name and 
> are therefore of little use if either multiple slots are executed on a single 
> TM or multiple checkpoints run in parallel.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to