[
https://issues.apache.org/jira/browse/FLINK-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566554#comment-16566554
]
ASF GitHub Bot commented on FLINK-9887:
---------------------------------------
tzulitai commented on a change in pull request #6467: [FLINK-9887] Ensure
serializer upgrades work with timer service remake
URL: https://github.com/apache/flink/pull/6467#discussion_r207162514
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerSerializer.java
##########
@@ -230,16 +264,29 @@ public TypeSerializerConfigSnapshot
snapshotConfiguration() {
*/
public static class TimerSerializerConfigSnapshot<K, N> extends
CompositeTypeSerializerConfigSnapshot {
+ private static final int VERSION = 0;
+
public TimerSerializerConfigSnapshot() {
}
- public TimerSerializerConfigSnapshot(TypeSerializer<K>
keySerializer, TypeSerializer<N> namespaceSerializer) {
- super(keySerializer, namespaceSerializer);
+ public TimerSerializerConfigSnapshot(
+ @Nonnull TypeSerializer<K> keySerializer,
+ @Nonnull TypeSerializer<N> namespaceSerializer) {
+ super(init(keySerializer, namespaceSerializer));
Review comment:
Just curious:
does this `init` method exist just to ensure the ordering between the
`keySerializer` / `namespaceSerializer`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure serializer upgrades work with timer service remake
> ---------------------------------------------------------
>
> Key: FLINK-9887
> URL: https://issues.apache.org/jira/browse/FLINK-9887
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
