[
https://issues.apache.org/jira/browse/FLINK-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566553#comment-16566553
]
ASF GitHub Bot commented on FLINK-9887:
---------------------------------------
tzulitai commented on a change in pull request #6467: [FLINK-9887] Ensure
serializer upgrades work with timer service remake
URL: https://github.com/apache/flink/pull/6467#discussion_r207163024
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java
##########
@@ -46,12 +46,11 @@
@Internal
public class InternalTimeServiceManager<K> {
- //TODO guard these constants with a test
- private static final String TIMER_STATE_PREFIX = "_timer_state";
- private static final String PROCESSING_TIMER_PREFIX =
TIMER_STATE_PREFIX + "/processing_";
- private static final String EVENT_TIMER_PREFIX = TIMER_STATE_PREFIX +
"/event_";
- private final int totalKeyGroups;
+ static final String TIMER_STATE_PREFIX = "_timer_state";
Review comment:
Add `@VisibleForTesting` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure serializer upgrades work with timer service remake
> ---------------------------------------------------------
>
> Key: FLINK-9887
> URL: https://issues.apache.org/jira/browse/FLINK-9887
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
