GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/989
[FLINK-2486]Remove unwanted null check in removeInstance function
removeInstance() is called in
getFreeSlotForTask()/getNewSlotForSharingGroup()/handleNewSlot()/instanceDied()/newInstanceAvailable().
1.getFreeSlotForTask()/getNewSlotForSharingGroup()/handleNewSlot() only
catch InstanceDiedException, if instance is null, removeInstance() will not
work.
2.instanceDied()/newInstanceAvailable() has check instance ant the head of
function,so the instance parameter of removeInstance() is not null.
So null check of instance in removeInstance() is unwanted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ffbin/flink FLINK-2486
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #989
----
commit 32c81aef41a46b47b591b04cb20914a32ddac9b8
Author: ffbin <[email protected]>
Date: 2015-08-05T01:48:51Z
[FLINK-2486]Remove unwanted null check in removeInstance function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
