Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/989#issuecomment-131165838
Sorry for catching this so late.
I actually put such "sanity checks" in a lot of places in the code I write,
and they have served well.
In the case where everything is all right, they are not necessary.
As soon as someone changes the code that calls this function (may happen in
the future), this can help catching bugs (fail fast principle).
I would like to keep such checks, they really do not hurt, and possibly
help in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
