[
https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568076#comment-16568076
]
ASF GitHub Bot commented on FLINK-9134:
---------------------------------------
twalthr commented on a change in pull request #6484: [FLINK-9134] [table]
upgrade Calcite dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207497685
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
##########
@@ -106,6 +109,10 @@ class ExternalCatalogSchema(
def registerSubSchemas(plusOfThis: SchemaPlus) {
catalog.listSubCatalogs().asScala.foreach(db => plusOfThis.add(db,
getSubSchema(db)))
}
+
+ override def getType(s: String): RelProtoDataType = null
+
+ override def getTypeNames: JSet[String] = ImmutableSet.of()
Review comment:
We should try to avoid guava. Use `java.util.Collections#unmodifiableSet`
instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite dependency to 1.17
> ---------------------------------
>
> Key: FLINK-9134
> URL: https://issues.apache.org/jira/browse/FLINK-9134
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
> Labels: pull-request-available
>
> This is an umbrella issue for tasks that need to be performed when upgrading
> to Calcite 1.17 once it is released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
