[
https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568079#comment-16568079
]
ASF GitHub Bot commented on FLINK-9134:
---------------------------------------
twalthr commented on a change in pull request #6484: [FLINK-9134] [table]
upgrade Calcite dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207504462
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowAggregateReduceFunctionsRule.scala
##########
@@ -55,19 +58,12 @@ class WindowAggregateReduceFunctionsRule extends
AggregateReduceFunctionsRule(
newAgg))
}
- override def newCalcRel(
- relBuilder: RelBuilder,
- oldAgg: Aggregate,
- exprs: util.List[RexNode]): Unit = {
-
- // add all named properties of the window to the selection
- val oldWindowAgg = oldAgg.asInstanceOf[LogicalWindowAggregate]
- oldWindowAgg.getNamedProperties.foreach(np =>
exprs.add(relBuilder.field(np.name)))
-
- // create a LogicalCalc that computes the complex aggregates and forwards
the window properties
- relBuilder.project(exprs, oldAgg.getRowType.getFieldNames)
+ override def newCalcRel(relBuilder: RelBuilder, rowType: RelDataType, exprs:
util.List[RexNode]) {
Review comment:
Please format the code again and add some inline comments to know what is
happening here. Add `:Unit` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite dependency to 1.17
> ---------------------------------
>
> Key: FLINK-9134
> URL: https://issues.apache.org/jira/browse/FLINK-9134
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
> Labels: pull-request-available
>
> This is an umbrella issue for tasks that need to be performed when upgrading
> to Calcite 1.17 once it is released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
