[ 
https://issues.apache.org/jira/browse/FLINK-10061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569985#comment-16569985
 ] 

ASF GitHub Bot commented on FLINK-10061:
----------------------------------------

tragicjun edited a comment on issue #6495: [FLINK-10061] [table] [kafka] Fix 
unsupported reconfiguration in KafkaTableSink
URL: https://github.com/apache/flink/pull/6495#issuecomment-410655698
 
 
   Thanks @twalthr for reviewing. Actually I was using 
`TableEnvironment.connect()` but got used to `writeToSink` style of defining 
sinks. I think as long as the `writeToSink` remains there, it is hard to 
prevent legacy code from using it, which would lead to confusion. 
   
   I assumed that `KafkaTableSink` is internal class and change the API 
semantics causes no confusion (no one would actually invoke 
KafkaTableSink.configure() apart from internal classes). It is a quick way of 
resolving the issue and adding a query/sink filedTypes check as well. Please 
let me know if anything I was missing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Fix unsupported reconfiguration in KafkaTableSink
> -------------------------------------------------
>
>                 Key: FLINK-10061
>                 URL: https://issues.apache.org/jira/browse/FLINK-10061
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.6.0
>            Reporter: Jun Zhang
>            Assignee: Jun Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.1, 1.7.0
>
>
> When using KafkaTableSink in "table.writeToSink(), the following exception is 
> thrown:
> {quote} java.lang.UnsupportedOperationException: Reconfiguration of this sink 
> is not supported.
> {quote}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to