azagrebin commented on a change in pull request #5304: [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8 URL: https://github.com/apache/flink/pull/5304#discussion_r207971760
########## File path: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java ########## @@ -123,6 +124,7 @@ public SimpleConsumerThread( this.fetchSize = getInt(config, "fetch.message.max.bytes", 1048576); this.bufferSize = getInt(config, "socket.receive.buffer.bytes", 65536); this.reconnectLimit = getInt(config, "flink.simple-consumer-reconnectLimit", 3); + this.clientId = config.getProperty("group.id", "flink-kafka-consumer-legacy-" + broker.id()); Review comment: If it is about client id in Kafka `SimpleConsumer`, why is this option named `group.id` and not `client.id`? As I understand, Flink job can be just one of consumers in a group. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services