[
https://issues.apache.org/jira/browse/FLINK-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571264#comment-16571264
]
ASF GitHub Bot commented on FLINK-9013:
---------------------------------------
dawidwys commented on a change in pull request #6294: [FLINK-9013][docs]
Document yarn.containers.vcores only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208142810
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/description/TextElement.java
##########
@@ -53,6 +55,16 @@ public static TextElement text(String text) {
return new TextElement(text, Collections.emptyList());
}
+ /**
+ * Tries to format the text as code.
+ *
+ * @return text element with applied formatting
+ */
+ public TextElement formatAsCode() {
Review comment:
I thought about it. The reason why I chose it as part of `TextElement` is
that this way we could implement styles as e.g. div classes in a single node.
With explicit element we would always need to model it as node hierarchy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Document yarn.containers.vcores only being effective when adapting YARN config
> ------------------------------------------------------------------------------
>
> Key: FLINK-9013
> URL: https://issues.apache.org/jira/browse/FLINK-9013
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, YARN
> Affects Versions: 1.5.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.3
>
>
> Even after specifying {{yarn.containers.vcores}} and having Flink request
> such a container from YARN, it may not take these into account at all and
> return a container with 1 vcore.
> The YARN configuration needs to be adapted to take the vcores into account,
> e.g. by setting the {{FairScheduler}} in {{yarn-site.xml}}:
> {code}
> <property>
> <name>yarn.resourcemanager.scheduler.class</name>
>
> <value>org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler</value>
> </property>
> {code}
> This fact should be documented at least at the configuration parameter
> documentation of {{yarn.containers.vcores}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
