[
https://issues.apache.org/jira/browse/FLINK-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571392#comment-16571392
]
ASF GitHub Bot commented on FLINK-6847:
---------------------------------------
twalthr commented on a change in pull request #6282: [FLINK-6847][FLINK-6813]
[table] TimestampDiff table api and sql support
URL: https://github.com/apache/flink/pull/6282#discussion_r208163167
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
##########
@@ -861,6 +865,35 @@ object ScalarOperators {
(l, r) => s"${qualifyMethod(BuiltInMethod.ADD_MONTHS.method)}($l,
$op($r))"
}
+ case (l: SqlTimeTypeInfo[_], r: SqlTimeTypeInfo[_]) if !plus =>
+ generateOperatorIfNotNull(nullCheck, LONG_TYPE_INFO, left, right) {
+ (ll, rr) => typeName match {
+ case SqlTypeName.INTERVAL_YEAR | SqlTypeName.INTERVAL_MONTH =>
+ (l, r) match {
+ case (SqlTimeTypeInfo.TIMESTAMP, SqlTimeTypeInfo.DATE) =>
+ s"${qualifyMethod(BuiltInMethod.SUBTRACT_MONTHS.method)}" +
+ s"($ll, $rr * ${MILLIS_PER_DAY}L)"
+ case (SqlTimeTypeInfo.DATE, SqlTimeTypeInfo.TIMESTAMP) =>
+ s"${qualifyMethod(BuiltInMethod.SUBTRACT_MONTHS.method)}" +
+ s"($ll * ${MILLIS_PER_DAY}L, $rr)"
+ case _ =>
+
s"${qualifyMethod(BuiltInMethod.SUBTRACT_MONTHS.method)}($ll, $rr)"
+ }
+
+ case _ =>
+ (l, r) match {
+ case (SqlTimeTypeInfo.TIMESTAMP, SqlTimeTypeInfo.TIMESTAMP) =>
+ s"$ll $op $rr"
Review comment:
When setting a breakpoint here, you can see that a `TimeIntervalTypeInfo` is
requested but we return a `LongTypeInfo` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add TIMESTAMPDIFF supported in TableAPI
> ---------------------------------------
>
> Key: FLINK-6847
> URL: https://issues.apache.org/jira/browse/FLINK-6847
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: sunjincheng
> Priority: Major
> Labels: pull-request-available, starter
>
> see FLINK-6813
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
