hequn8128 commented on a change in pull request #6521: [FLINK-5315][table]
Adding support for distinct operation for table API on DataStream
URL: https://github.com/apache/flink/pull/6521#discussion_r208549921
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
##########
@@ -235,6 +235,13 @@ case class Aggregate(
groupingExprs.foreach(validateGroupingExpression)
def validateAggregateExpression(expr: Expression): Unit = expr match {
+ case distinctExpr: DistinctAgg =>
+ distinctExpr.child match {
+ case _: AggFunctionCall =>
+ failValidation("UDAGG should prepend 'distinct' modifier before
arguments")
Review comment:
UDAGG should prepend 'distinct' modifier before arguments, for example,
udagg.distinct('a, 'b).
Add an example may be more understandable. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
