hequn8128 commented on a change in pull request #6521: [FLINK-5315][table]
Adding support for distinct operation for table API on DataStream
URL: https://github.com/apache/flink/pull/6521#discussion_r208549873
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
##########
@@ -136,4 +136,11 @@ abstract class AggregateFunction[T, ACC] extends
UserDefinedFunction {
* accumulator type should be automatically inferred.
*/
def getAccumulatorType: TypeInformation[ACC] = null
+
+ private[flink] var isDistinctAgg: Boolean = false
+
+ private[flink] def distinct: AggregateFunction[T, ACC] = {
+ this.isDistinctAgg = true
Review comment:
Throw exception when `isDistinctAgg` is true already? In order to validate
expressions such as `udagg.distinct.distinct('a, 'b)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
