[ 
https://issues.apache.org/jira/browse/FLINK-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576309#comment-16576309
 ] 

ASF GitHub Bot commented on FLINK-9850:
---------------------------------------

pnowojski commented on a change in pull request #6367: [FLINK-9850] Add a 
string to the print method to identify output for DataStream
URL: https://github.com/apache/flink/pull/6367#discussion_r209233947
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java
 ##########
 @@ -40,6 +40,8 @@
        private boolean target;
        private transient PrintStream stream;
        private transient String prefix;
+       private String sinkIdentifier;
+       private transient String completedPrefix;
 
 Review comment:
   Please drop `prefix` field, it's only a local variable now. Also please 
change `target` and `sinkIdentifier` into `final` fields.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add a string to the print method to identify output for DataStream
> ------------------------------------------------------------------
>
>                 Key: FLINK-9850
>                 URL: https://issues.apache.org/jira/browse/FLINK-9850
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataStream API
>            Reporter: Hequn Cheng
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>
> The output of the print method of {[DataSet}} allows the user to supply a 
> String to identify the output(see 
> [FLINK-1486|https://issues.apache.org/jira/browse/FLINK-1486]). But 
> {[DataStream}} doesn't support now. It is valuable to add this feature for 
> {{DataStream}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to