[
https://issues.apache.org/jira/browse/FLINK-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579782#comment-16579782
]
ASF GitHub Bot commented on FLINK-9850:
---------------------------------------
pnowojski commented on issue #6367: [FLINK-9850] Add a string to the print
method to identify output for DataStream
URL: https://github.com/apache/flink/pull/6367#issuecomment-412868964
Yes exactly. More precisely as I wrote in one of the previous comments, this
`TaskOutputWriter` (`TaskStandardOutputWriter`?) would deduplicate logic from
those methods:
- open
- writeRecord/invoke
- toString
- close (those probably should be dropped because of NPE.)
Because their logic is identical between `PrintSinkFunction` and
`PrintingOutputFormat` while their implementation is already inconsistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add a string to the print method to identify output for DataStream
> ------------------------------------------------------------------
>
> Key: FLINK-9850
> URL: https://issues.apache.org/jira/browse/FLINK-9850
> Project: Flink
> Issue Type: New Feature
> Components: DataStream API
> Reporter: Hequn Cheng
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> The output of the print method of {[DataSet}} allows the user to supply a
> String to identify the output(see
> [FLINK-1486|https://issues.apache.org/jira/browse/FLINK-1486]). But
> {[DataStream}} doesn't support now. It is valuable to add this feature for
> {{DataStream}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
