ASF GitHub Bot commented on FLINK-9642:

Aitozi commented on a change in pull request #6205: [FLINK-9642]Reduce the 
count to deal with state during a CEP process
URL: https://github.com/apache/flink/pull/6205#discussion_r209419821

 File path: 
 @@ -161,40 +100,30 @@ public void init(
-       /**
-        * Stores given value (value + timestamp) under the given state. It 
assigns a preceding element
-        * relation to the previous entry.
-        *
-        * @param stateName      name of the state that the event should be 
assigned to
-        * @param eventId        unique id of event assigned by this 
-        * @param previousNodeId id of previous entry (might be null if start 
of new run)
-        * @param version        Version of the previous relation
-        * @return assigned id of this element
-        * @throws Exception Thrown if the system cannot access the state.
-        */
-       public NodeId put(
-                       final String stateName,
-                       final EventId eventId,
-                       @Nullable final NodeId previousNodeId,
-                       final DeweyNumber version) throws Exception {
+       public SharedBufferAccessor<V> getAccessor() {
+               return new SharedBufferAccessor<>(this);
+       }
-               if (previousNodeId != null) {
-                       lockNode(previousNodeId);
+       public void advanceTime(long timestamp) throws Exception {
 Review comment:
   This need to be called in nfa package, I think it should be public.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Reduce the count to deal with state during a CEP process 
> ---------------------------------------------------------
>                 Key: FLINK-9642
>                 URL: https://issues.apache.org/jira/browse/FLINK-9642
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.6.0
>            Reporter: aitozi
>            Assignee: aitozi
>            Priority: Major
>              Labels: pull-request-available
> With the rework of sharedBuffer Flink-9418, the lock & release operation is 
> deal with rocksdb state which is different from the previous version which 
> will read the state of sharedBuffer all to memory, i think we can add a cache 
> or variable in sharedbuffer to cache the LockAble Object to mark the ref 
> change in once process in NFA, this will reduce the count when the events 
> point to the same NodeId.. And flush the result to MapState at the end of 
> process. 

This message was sent by Atlassian JIRA

Reply via email to