walterddr commented on a change in pull request #6473: [FLINK-9999] [table] Add 
ISNUMERIC supported in Table API/SQL
URL: https://github.com/apache/flink/pull/6473#discussion_r209430879
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/stringExpressions.scala
 ##########
 @@ -358,6 +358,29 @@ case class Rpad(text: Expression, len: Expression, pad: 
Expression)
   }
 }
 
+case class IsNumeric(child: Expression) extends UnaryExpression with 
InputTypeSpec {
+
+  override private[flink] def expectedTypes: Seq[TypeInformation[_]] = 
Seq(STRING_TYPE_INFO)
+
+  override private[flink] def resultType: TypeInformation[_] = INT_TYPE_INFO
+
+  override private[flink] def validateInput(): ValidationResult = {
+    if (child.resultType == STRING_TYPE_INFO) {
 
 Review comment:
   Wasn't sure if there is a SQL standard for `isNumeric` but some SQL servers 
such as MS and Transact do support `isNumeric(expression)` where expression can 
actually be a Numeric type (INT, BIGINT, DOUBLE, etc). Maybe @twalthr have more 
context ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to