[
https://issues.apache.org/jira/browse/FLINK-9900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579487#comment-16579487
]
ASF GitHub Bot commented on FLINK-9900:
---------------------------------------
zentol commented on a change in pull request #6468: [FLINK-9900][tests] Include
more information on timeout in Zookeeper HA ITCase
URL: https://github.com/apache/flink/pull/6468#discussion_r209879523
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
##########
@@ -256,13 +262,54 @@ public FileVisitResult visitFile(Path file,
BasicFileAttributes attrs) throws IO
() -> clusterClient.getJobStatus(jobID),
Time.milliseconds(50),
deadline,
- (jobStatus) -> jobStatus == JobStatus.FINISHED,
+ JobStatus::isGloballyTerminalState,
TestingUtils.defaultScheduledExecutor());
- assertEquals(JobStatus.FINISHED, jobStatusFuture.get());
+ try {
+ assertEquals(JobStatus.FINISHED, jobStatusFuture.get());
+ } catch (Throwable e) {
+ // include additional debugging information
+ StringWriter error = new StringWriter();
+ try (PrintWriter out = new PrintWriter(error)) {
+ out.println("The job did not finish in time.");
+
out.println("allowedInitializeCallsWithoutRestore= " +
CheckpointBlockingFunction.allowedInitializeCallsWithoutRestore.get());
+ out.println("illegalRestores= " +
CheckpointBlockingFunction.illegalRestores.get());
+ out.println("successfulRestores= " +
CheckpointBlockingFunction.successfulRestores.get());
+ out.println("afterMessWithZooKeeper= " +
CheckpointBlockingFunction.afterMessWithZooKeeper.get());
+ out.println("failedAlready= " +
CheckpointBlockingFunction.failedAlready.get());
+ out.println("currentJobStatus= " +
clusterClient.getJobStatus(jobID).get());
+ out.println("numRestarts= " +
RestartReporter.numRestarts.getValue());
+ out.println("threadDump= " +
generateThreadDump());
+ }
+ throw new AssertionError(error.toString(),
ExceptionUtils.stripCompletionException(e));
+ }
assertThat("We saw illegal restores.",
CheckpointBlockingFunction.illegalRestores.get(), is(0));
}
+ private static String generateThreadDump() {
+ final StringBuilder dump = new StringBuilder();
+ final ThreadMXBean threadMXBean =
ManagementFactory.getThreadMXBean();
+ final ThreadInfo[] threadInfos =
threadMXBean.getThreadInfo(threadMXBean.getAllThreadIds(), 100);
+ for (ThreadInfo threadInfo : threadInfos) {
+ dump.append('"');
+ dump.append(threadInfo.getThreadName());
+ dump.append('"');
+ final Thread.State state = threadInfo.getThreadState();
+ dump.append(System.lineSeparator());
+ dump.append(" java.lang.Thread.State: ");
+ dump.append(state);
+ final StackTraceElement[] stackTraceElements =
threadInfo.getStackTrace();
+ for (final StackTraceElement stackTraceElement :
stackTraceElements) {
Review comment:
The output is nicer if we go with the original option:
without Throwable (i.e. current PR revision):
```
"Monitor Ctrl-Break"
java.lang.Thread.State: RUNNABLE
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
at java.net.SocketInputStream.read(SocketInputStream.java:170)
at java.net.SocketInputStream.read(SocketInputStream.java:141)
at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
at java.io.InputStreamReader.read(InputStreamReader.java:184)
at java.io.BufferedReader.fill(BufferedReader.java:161)
at java.io.BufferedReader.readLine(BufferedReader.java:324)
at java.io.BufferedReader.readLine(BufferedReader.java:389)
at
com.intellij.rt.execution.application.AppMainV2$1.run(AppMainV2.java:64)
```
with throwable:
```
"Monitor Ctrl-Break"
java.lang.Thread.State: RUNNABLE
java.lang.Throwable
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
at java.net.SocketInputStream.read(SocketInputStream.java:170)
at java.net.SocketInputStream.read(SocketInputStream.java:141)
at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
at java.io.InputStreamReader.read(InputStreamReader.java:184)
at java.io.BufferedReader.fill(BufferedReader.java:161)
at java.io.BufferedReader.readLine(BufferedReader.java:324)
at java.io.BufferedReader.readLine(BufferedReader.java:389)
at
com.intellij.rt.execution.application.AppMainV2$1.run(AppMainV2.java:64)
```
The `java.lang.Throwable` pops up for every thread. It would be better if it
looks as one would expect a thread dump to look like. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Failed to testRestoreBehaviourWithFaultyStateHandles
> (org.apache.flink.test.checkpointing.ZooKeeperHighAvailabilityITCase)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-9900
> URL: https://issues.apache.org/jira/browse/FLINK-9900
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.1, 1.6.0
> Reporter: zhangminglei
> Assignee: Chesnay Schepler
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.5.3, 1.6.1, 1.7.0
>
>
> https://api.travis-ci.org/v3/job/405843617/log.txt
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 124.598 sec
> <<< FAILURE! - in
> org.apache.flink.test.checkpointing.ZooKeeperHighAvailabilityITCase
>
> testRestoreBehaviourWithFaultyStateHandles(org.apache.flink.test.checkpointing.ZooKeeperHighAvailabilityITCase)
> Time elapsed: 120.036 sec <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 120000
> milliseconds
> at sun.misc.Unsafe.park(Native Method)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at
> java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1693)
> at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3323)
> at
> java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1729)
> at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895)
> at
> org.apache.flink.test.checkpointing.ZooKeeperHighAvailabilityITCase.testRestoreBehaviourWithFaultyStateHandles(ZooKeeperHighAvailabilityITCase.java:244)
> Results :
> Tests in error:
>
> ZooKeeperHighAvailabilityITCase.testRestoreBehaviourWithFaultyStateHandles:244
> » TestTimedOut
> Tests run: 1453, Failures: 0, Errors: 1, Skipped: 29
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
