[
https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660102#comment-14660102
]
ASF GitHub Bot commented on FLINK-2457:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-128396895
Two comments on the singleton change:
- The Tuple0.class.newInstance() will now probably fail (due to the
private constructor)
- Java serialization still creates copies. Need to overwrite the
`readResolve()` method to create proper singletons.
- It is probably okay allow Tuple0 instances to be created. We could
simply providing a static shareable instance in the class for convenience
(soft-singleton style).
@twalthr Are the TypeExctractor related changes good?
Thanks for reverting the whitespace changes. I did actually not expect
that, it was more a comment for future pull requests...
> Integrate Tuple0
> ----------------
>
> Key: FLINK-2457
> URL: https://issues.apache.org/jira/browse/FLINK-2457
> Project: Flink
> Issue Type: Improvement
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Tuple0 is not cleanly integrated:
> - missing serialization/deserialization support in runtime
> - Tuple.getTupleClass(int arity) cannot handle arity zero, ie, cannot create
> an instance of Tuple0
> Tuple0 is currently only used in Python API, but will be integrated into
> Storm compatibility, too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
