pnowojski commented on a change in pull request #6555: [FLINK-10142][network]
reduce locking around credit notification
URL: https://github.com/apache/flink/pull/6555#discussion_r210915852
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -357,19 +357,20 @@ private void writeAndFlushNextMessageIfPossible(Channel
channel) {
return;
}
- //It is no need to notify credit for the released
channel.
- if (!inputChannel.isReleased()) {
- AddCredit msg = new AddCredit(
- inputChannel.getPartitionId(),
-
inputChannel.getAndResetUnannouncedCredit(),
- inputChannel.getInputChannelId());
+ if (inputChannel.isReleased()) {
Review comment:
Are those changes in this file optimising anything? Or is this irrelevant
change to the the rest of the commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
