[ 
https://issues.apache.org/jira/browse/FLINK-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585022#comment-16585022
 ] 

ASF GitHub Bot commented on FLINK-10145:
----------------------------------------

yanghua commented on a change in pull request #6576: [FLINK-10145][table] Add 
replace supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6576#discussion_r211091915
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/stringExpressions.scala
 ##########
 @@ -410,3 +410,27 @@ case class ToBase64(child: Expression) extends 
UnaryExpression with InputTypeSpe
   override def toString: String = s"($child).toBase64"
 
 }
+
+/**
+  * Returns the string `str` with all non-overlapping occurrences
 
 Review comment:
   remove all the  "``" , just describe the function

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add replace supported in TableAPI and SQL
> -----------------------------------------
>
>                 Key: FLINK-10145
>                 URL: https://issues.apache.org/jira/browse/FLINK-10145
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Guibo Pan
>            Assignee: Guibo Pan
>            Priority: Major
>              Labels: pull-request-available
>
> replace is an useful function for String. 
> for example:
> {code:java}
> select replace("Hello World", "World", "Flink") // return "Hello Flink"
> select replace("ababab", "abab", "z") // return "zab"
> {code}
> It is supported as a UDF in Hive, more details please see[1]
> [1]: 
> https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-StringFunctions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to