[
https://issues.apache.org/jira/browse/FLINK-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585024#comment-16585024
]
ASF GitHub Bot commented on FLINK-10145:
----------------------------------------
yanghua commented on a change in pull request #6576: [FLINK-10145][table] Add
replace supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6576#discussion_r211091930
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/SqlExpressionTest.scala
##########
@@ -149,6 +149,9 @@ class SqlExpressionTest extends ExpressionTestBase {
testSqlApi("RPAD('hi',4,'??')", "hi??")
testSqlApi("FROM_BASE64('aGVsbG8gd29ybGQ=')", "hello world")
testSqlApi("TO_BASE64('hello world')", "aGVsbG8gd29ybGQ=")
+ testSqlApi("REPLACE('hello world', 'world', 'flink')", "hello flink")
+ testSqlApi("REPLACE('ababab', 'abab', 'Z')", "Zab")
+ testSqlApi("REPLACE('ababab', 'a', '')", "bbb")
Review comment:
It seems this test file is a show case, so just add one example .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add replace supported in TableAPI and SQL
> -----------------------------------------
>
> Key: FLINK-10145
> URL: https://issues.apache.org/jira/browse/FLINK-10145
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Guibo Pan
> Assignee: Guibo Pan
> Priority: Major
> Labels: pull-request-available
>
> replace is an useful function for String.
> for example:
> {code:java}
> select replace("Hello World", "World", "Flink") // return "Hello Flink"
> select replace("ababab", "abab", "z") // return "zab"
> {code}
> It is supported as a UDF in Hive, more details please see[1]
> [1]:
> https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-StringFunctions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
