[
https://issues.apache.org/jira/browse/FLINK-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585618#comment-16585618
]
ASF GitHub Bot commented on FLINK-6670:
---------------------------------------
zentol opened a new pull request #6581: [FLINK-6670][tests] Remove
CommonTestUtils#createTempDirectory
URL: https://github.com/apache/flink/pull/6581
## What is the purpose of the change
This PR removes `CommonTestUtils#createTempDirectory`, as `TemporaryFolders`
should be used for creating temporary folders during tests.
As such all usages were replaced with `TemporaryFolders`.
## Verifying this change
This change is already covered by existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> remove CommonTestUtils.createTempDirectory()
> --------------------------------------------
>
> Key: FLINK-6670
> URL: https://issues.apache.org/jira/browse/FLINK-6670
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Reporter: Nico Kruber
> Assignee: Chesnay Schepler
> Priority: Minor
> Labels: pull-request-available
>
> {{CommonTestUtils.createTempDirectory()}} encourages a dangerous design
> pattern with potential concurrency issues in the unit tests as well as the
> need to cleanup the created directories.
> Instead, it should be solved by using the following pattern:
> {code:java}
> @Rule
> public TemporaryFolder tempFolder = new TemporaryFolder();
> {code}
> We should therefore remove {{CommonTestUtils.createTempDirectory()}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
