yanghua commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors URL: https://github.com/apache/flink/pull/6577#issuecomment-414650807 @pnowojski this is a big PR, may need some discussion, some questions : * I know that most of the code for some tests is repetitive, but I have to copy them because I need to modify the relevant statements that create objects, such as `FlinkKafkaConsumer011` -> `FlinkKafkaConsumer10`. * At first I didn't know if I tried to keep the existing code implementation unchanged. Now I know that we can make some abstractions to reuse some code, and I will make some improvements. * Do you think we need a single module named `flink-connector-kafka-1.1`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
