yanghua commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors URL: https://github.com/apache/flink/pull/6577#issuecomment-414957744 @pnowojski Ok, you are a gentleman and gave me a lot of good advice. I think it's necessary to create a new module for each large version of kafka, but if we create a separate module for each sub version of kafka, it does seem a bit more. But we did use some kafka non-public APIs, and I don't know if they have the possibility to be modified in the sub version. If you don't add a separate module for the sub version, you will only be able to use branch decisions like if/else in the future. Are you working in the same place with @aljoscha ? If so, can you discuss this issue offline? And I will first refactor the current duplicate test code. Do you agree?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
