[ 
https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662340#comment-14662340
 ] 

ASF GitHub Bot commented on FLINK-2437:
---------------------------------------

Github user ggevay commented on the pull request:

    https://github.com/apache/flink/pull/960#issuecomment-128819328
  
    They print things like
    `Class class malom.GameState must have a default constructor to be used as 
a POJO.`
    If you think that the double "class" should be left the way it is, then I'm 
sorry for changing them. I have now removed the changes from the PR.
    
    I have also added a test.


> TypeExtractor.analyzePojo has some problems around the default constructor 
> detection
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-2437
>                 URL: https://issues.apache.org/jira/browse/FLINK-2437
>             Project: Flink
>          Issue Type: Bug
>          Components: Type Serialization System
>            Reporter: Gabor Gevay
>            Assignee: Gabor Gevay
>            Priority: Minor
>
> If a class does have a default constructor, but the user forgot to make it 
> public, then TypeExtractor.analyzePojo still thinks everything is OK, so it 
> creates a PojoTypeInfo. Then PojoSerializer.createInstance blows up.
> Furthermore, a "return null" seems to be missing from the then case of the if 
> after catching the NoSuchMethodException which would also cause a headache 
> for PojoSerializer.
> An additional minor issue is that the word "class" is printed twice in 
> several places, because class.toString also prepends it to the class name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to