[
https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682411#comment-14682411
]
ASF GitHub Bot commented on FLINK-2437:
---------------------------------------
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/960#issuecomment-130050479
OK, I re-added the changes to remove the double "class". (Note, that the
3rd bullet in the opening comment refers to this doubling.)
> TypeExtractor.analyzePojo has some problems around the default constructor
> detection
> ------------------------------------------------------------------------------------
>
> Key: FLINK-2437
> URL: https://issues.apache.org/jira/browse/FLINK-2437
> Project: Flink
> Issue Type: Bug
> Components: Type Serialization System
> Reporter: Gabor Gevay
> Assignee: Gabor Gevay
> Priority: Minor
>
> If a class does have a default constructor, but the user forgot to make it
> public, then TypeExtractor.analyzePojo still thinks everything is OK, so it
> creates a PojoTypeInfo. Then PojoSerializer.createInstance blows up.
> Furthermore, a "return null" seems to be missing from the then case of the if
> after catching the NoSuchMethodException which would also cause a headache
> for PojoSerializer.
> An additional minor issue is that the word "class" is printed twice in
> several places, because class.toString also prepends it to the class name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
